📝 Document .in_() method
#619
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
📝 Docs preview for commit bd737cc at: https://8cafcc3f.sqlmodel.pages.dev Modified Pages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I'm pretty new to this project and I think this is the best time to contribute documentation.
The tutorial is amazing, but missing a formal reference makes finding some advanced features a bit difficult. For instance, since I'm still not 100% sure how the integration with SQLAlchemy works, I had to search how to do
in_. I found this issue here #353 which explains perfectly how to do it.I've went ahead and added the documentation on the where tutorial. My only gotcha here is that the numeric examples make it hard to add new examples in between. I'm not sure renaming all the tutorials is the best approach. This is a very similar problem as creating taxonomies in design systems, this is why people name things in hundreds (100, 200, 300...), so if a new thing needs to be added in between it can be added without having to rename things afterwards. In my case, I've just added a 5 after the 6 to denote "this tutorial goes between the 6th and the 7th".
I hope this is useful!