Skip to content

✨ Use mysql's default string length for mariadb #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

✨ Use mysql's default string length for mariadb #882

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
27ae20a
use mysql's default string length for mariadb
itsbekas Apr 4, 2024
2dfc84c
use max_length argument as varchar length
itsbekas Apr 13, 2024
89d8cbb
Merge branch 'main' into main
itsbekas Apr 13, 2024
055b50c
Merge branch 'tiangolo:main' into main
itsbekas Apr 30, 2024
2e1fa51
Merge branch 'main' into main
YuriiMotov Aug 22, 2025
ef88234
Apply review comments
YuriiMotov Sep 27, 2025
7f8bc7d
Merge branch 'main' into main
YuriiMotov Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sqlmodel/_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,9 @@ def get_field_metadata(field: Any) -> Any:
for meta in field.metadata:
if isinstance(meta, (PydanticMetadata, MaxLen)):
return meta
return FakeMetadata()
fake = FakeMetadata()
fake.max_length = getattr(meta, "max_length", None)
return fake

def post_init_field_info(field_info: FieldInfo) -> None:
return None
Expand Down
4 changes: 3 additions & 1 deletion sqlmodel/sql/sqltypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ class AutoString(types.TypeDecorator): # type: ignore

def load_dialect_impl(self, dialect: Dialect) -> "types.TypeEngine[Any]":
impl = cast(types.String, self.impl)
if impl.length is None and dialect.name == "mysql":
if impl.length is None and (
dialect.name == "mysql" or dialect.name == "mariadb"
):
return dialect.type_descriptor(types.String(self.mysql_default_length))
return super().load_dialect_impl(dialect)