Fix #326: Add a checkbox to build with clang #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-51
to
-53
| pgo: | ||
| description: "Build with PGO" | ||
| type: boolean |
Contributor
There was a problem hiding this comment.
Out of curiosity, what effect does removing this do?
Contributor
Author
There was a problem hiding this comment.
Github has a limit of only 10 options on a workflow-dispatch trigger (that's the thing that makes a drop down of options in the web interface). In order to accommodate one more checkbox for clang, I had to remove this one. We never should be benchmarking without PGO anyway, so I thought this was the safest to remove.
Contributor
There was a problem hiding this comment.
Ah ok that makes sense. Thanks! I think the next thing to remove if we run out of options again would probably be the tier 2 interpreter since at this point we probably don't care about its performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a checkbox to build CPython with "latest" clang, and then will flag the results so we know it's a special configuration.
This only works with macOS and Linux right now. Windows is possible but I plan to do it as a follow-on since it's a bit more involved.
Cc: @Fidget-Spinner, @brandtbucher