IO: optimize createSubfolders #1382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not worth using strncat, it is noticeably slower than pathTail in benchmarks. Let the code be a bit longer can get better performance. |
|
I don't like the change. Maybe you care the performance of functions that only run once, I don't. |
Currently, but may be reused in the future. Also, the new code is simple, we can do it better. fastfetch runs fastly is not only because it's wrote by c. |
|
I reused ffStrCopyN. Simpler code and better performance. |
CarterLi
added a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File names have known max length limits, so we can use a fixed length stack buf rather than heap allocations.
This reduces 2 heap allocations on the path "/home/apocelipes/.config/fastfetch" and makes
createSubfoldersrun 8% faster:After this optimization, the paramater
fileName's length must be less than the PATH_MAX/MAX_PATH, andopen/CreateFileAhas already checked this for us, so it's not worth to check it again in thecreateSubfolders.