Skip to content

Change FoxOS to WolfOS #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Mar 11, 2025
Merged

Change FoxOS to WolfOS #1534

merged 18 commits into from
Mar 11, 2025

Conversation

@WolfTech-Innovations
Copy link
Contributor

No description provided.

@CarterLi
Copy link
Member

CarterLi commented Feb 1, 2025

Was the OS renamed? Any context?

You need to move the distro definition to W section.

@WolfTech-Innovations
Copy link
Contributor Author

WolfTech-Innovations commented Feb 1, 2025 •
edited
Loading

For context, yes it was

@WolfTech-Innovations
Copy link
Contributor Author

WolfOS has been moved to W.

@FabioLolix FabioLolix mentioned this pull request Feb 1, 2025
Open
@CarterLi
Copy link
Member

CarterLi commented Feb 1, 2025

You should rearrange it in alphabetical order

@WolfTech-Innovations
Copy link
Contributor Author

I did.

@komaru-meow
Copy link
Contributor

komaru-meow commented Feb 5, 2025 •
edited
Loading

I did.

WolfOS is put before "WiiLinux", and the letter "i" comes before the letter "o".

@komaru-meow
Copy link
Contributor

image
are you kidding me? to be honest, if you want, i can make a pr on your fork to move it to the correct place

@WolfTech-Innovations
Copy link
Contributor Author

Alright, yeah

@WolfTech-Innovations
Copy link
Contributor Author

All done

CarterLi
CarterLi reviewed Feb 14, 2025
View reviewed changes
src/logo/builtin.c Outdated
};

static const FFlogo W[] = {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

CarterLi
CarterLi reviewed Feb 14, 2025
View reviewed changes
src/logo/builtin.c
// LAST
{},
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the new line back

@CarterLi
Copy link
Member

Your logo is too wide. See the requirement here: https://github.com/fastfetch-cli/fastfetch/issues/new?template=logo_request.yml

@komaru-meow
Copy link
Contributor

komaru-meow commented Feb 14, 2025 •
edited
Loading

I would also recommend squashing the commits, 11 commits for a simple distro rename on fastfetch is crazy.

@CarterLi
Copy link
Member

I would also recommend squashing the commits, 11 commits for a simple distro rename on fastfetch is crazy.

I always use Squash and merge so it is ok

@WolfTech-Innovations
Copy link
Contributor Author

All issues fixed.

@komaru-meow
Copy link
Contributor

you don't need to rebase the branch every time changes are added, the maintainer can rebase and merge

@CarterLi
Copy link
Member

Please fix the newline issues.

@komaru-meow
Copy link
Contributor

Crazy how this PR is still open. For me, mine got merged the 2nd time I checked it.

ItzLevvie
ItzLevvie suggested changes Mar 9, 2025
View reviewed changes
WolfTech Innovations and others added 2 commits March 10, 2025 06:12
@ItzLevvie
Update src/logo/builtin.c
09ea334 
Co-authored-by: Levvie - she/her <[email protected]>
@ItzLevvie
Update src/logo/builtin.c
e2a4384 
Co-authored-by: Levvie - she/her <[email protected]>
@CarterLi CarterLi merged commit b66a009 into fastfetch-cli:dev Mar 11, 2025
19 checks passed
sgse added a commit to sgse/fastfetch that referenced this pull request Mar 12, 2025
@sgse
Merge pull request #58 from fastfetch-cli/dev
528963c 
Logo (Builtin): Change FoxOS to WolfOS (fastfetch-cli#1534)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarterLi CarterLi CarterLi left review comments

+1 more reviewer

@ItzLevvie ItzLevvie ItzLevvie requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@WolfTech-Innovations @CarterLi @komaru-meow @ItzLevvie