-
-
Notifications
You must be signed in to change notification settings - Fork 606
Haiku fixes #1564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haiku fixes #1564
Conversation
For historical reasons int32 and int32_t are not compatible types.
|
init of haiku isn't pid 1? |
|
Does Host module work for you? |
No, pid 1 is the kernel actually, and unlike BeOS, Haiku shares the thread and team(process) namespaces, so like now launch_daemon is 57.
I seem to get some DMI info yes. |
In Haiku kernel is a userland process?
Does it print SM2 or SM3? |
|
Does Haiku have any API / syscalls to query DMI data? |
No but it is treated as a process regardless.
SM2. |
No, I don't even think we use these in the kernel, unlike ACPI. |
|
Strangely it doesn't work for @Begasus. Maybe there are some bugs in SM3 related code |
|
Or maybe it only works for 32bit? Could be a 64bit related bug in the mem driver. |
I do find this one; doesn't seem to be useful though: https://github.com/haiku/haiku/blob/master/headers/private/drivers/smbios.h |
It works for me in my VM, 64bit. But it also uses SM2 |
|
My compiler complains that variable mute is set but not used |
I reused code from setvolume, I wasn't sure on how to report it, either ignore or report 0% as volume? |
|
Probably related output in Terminal? |
|
Hmm it shouldn't print an error… |
|
I get this on both arch's |
|
It's odd, I wouldn't think the mixer would have different configurations. |
|
Best remove or disable it untill it could be figured out |
|
I don't see why you get an error message, the code only enumerates parameters, and only reads the gain one for now… |
Should problably mention it's not a build error, it shows up when running fastfetch in Terminal. :) |
|
Yes but we don't try to get the value yet… 🤷 |
|
Maybe showed up with the debug enabled? |
|
Oh I didn't know someone else wrote it already… :-D |
|
Ah, now after rebasing I get the same error 😅 |
|
Argh, sizeof(bool) is 1, not 4, which is why it complains. change isMute to int32. |
|
That worked, error is gone now. |
Fix 32 bit; add sound & init system.