Release: v2.40.0 #1656
Merged
Release: v2.40.0 #1656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wii-Linux-Ngx is no longer the most up to date version of Linux for the Wii. This change retains the original name for compatibility sake, and because Neagix's version does indeed still exist. It moves the ASCII art to a more generic file path, and introduces 2 new aliases for it: Wii-Linux, and WiiLinux.
And support more features
Detect more information including memory type
On some PowerPC devices (notably the Nintendo Wii and Nintendo Wii U), fastfetch detects the CPU incorrectly. It goes down the code path of 'detectSocName()', and actually matches the model of the device itself... as the CPU model name. This is obviously incorrect, and leads to reporting such as 'CPU: wii'. Disable this code path alltogether on PPC to prevent this, and just let it pull from cpuinfo. This lets it have correct CPU reporting, such as on the Wii, giving 'CPU: 750CL @ 0.73GHz'.
There was a problem hiding this comment.
Copilot reviewed 130 out of 137 changed files in this pull request and generated 1 comment.
Files not reviewed (7)
- CMakeLists.txt: Language not supported
- debian/changelog: Language not supported
- debian/files: Language not supported
- presets/examples/24.jsonc: Language not supported
- presets/examples/26.jsonc: Language not supported
- src/3rdparty/ags/repo.json: Language not supported
- src/3rdparty/display-library/repo.json: Language not supported
Comments suppressed due to low confidence (1)
src/common/parsing.c:201
- [nitpick] Verify that rounding durations by incrementing minutes when seconds are at least 30 aligns with the intended behavior across all cases.
if(seconds >= 30)
| { | ||
| ts.tv_sec += ts.tv_sec / 1000; | ||
| ts.tv_nsec += (ts.tv_nsec % 1000) * 1000000; | ||
| ts.tv_sec += timeout / 1000; |
There was a problem hiding this comment.
Ensure that after adjusting ts.tv_nsec, the code normalizes the timespec (i.e. converts excess nanoseconds into seconds) to prevent potential invalid timespec values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.