fish complete: add --logo-color-[1-9] completion
#1754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces fish shell completion support for the "--logo-color-[1-9]" flag, ensuring that each color flag (1 through 9) is individually handled.
- Uses a loop to generate individual completions for each logo-color value.
- Splits multi-imports into separate statements and improves error handling by catching and printing the exception.
| for key in data: | ||
| for flag in data[key]: | ||
| if flag["long"] == "logo-color-[1-9]": |
There was a problem hiding this comment.
[nitpick] Consider adding an inline comment explaining that the loop generates distinct completions for logo-color flags (1-9) to improve clarity for future maintainers.
CarterLi
reviewed
May 15, 2025
CarterLi
reviewed
May 15, 2025
|
@CarterLi I reverted the changes you mentioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fish completion support for
--logo-color-[1-9]flag.