Fix NetBSD CPU detection for PPC #1802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh yikes, my branch accidentally included some old Linux stuff I had lying around from last time, fixing that, one moment. Edit: Should be fixed now (oops!) |
Some devices store their CPU name in hw.model, so check that as well before giving up. Tested on NetBSD 10.1 evbppc/wii, and allows it to detect the CPU as "750 (Revision 2.0)".
techflashYT
force-pushed
the
fix-cpu-detect-ppc
branch
from
77ab331 to
2d97f62
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve CPU detection on NetBSD by adding a check for "hw.model" since some devices store their CPU name there.
- Updated the conditional logic in the CPU detection function to include "hw.model".
- Refined CPU information extraction for better support on NetBSD PPC systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some devices store their CPU name in hw.model, so this patch adds support for checking that as well before giving up. Tested on NetBSD 10.1 evbppc/wii, and allows it to detect the CPU as "750 (Revision 2.0)".