Release: v2.47.0 #1826
Merged
Release: v2.47.0 #1826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #1819 Signed-off-by: kevlo <[email protected]>
To improve visibility on white background
Also improve performance
…DPC and interrupt time
Because Windows 7 doesn't support it
This reverts commit bdbc885.
There was a problem hiding this comment.
Pull Request Overview
Adds support for Solaris/OpenIndiana, refines CPU usage measurement across platforms, improves macOS media detection, and updates logos and OS detections for various distributions.
- Introduce Solaris-specific detection modules (PhysicalDisk, Sound, GPU, BIOS)
- Improve CPU usage calculations on Linux, BSD & Windows using native APIs
- Refresh many logos to use default foreground color and add Xubuntu
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/util/windows/perflib_.h | Define PERF_MULTI_INSTANCES for Windows perflib usage |
| src/modules/cpuusage/cpuusage.c | Cap CPU percent to 100% on Windows |
| src/logo/image/*.c | Fix trailing semicolons removal in FF_LIBRARY macros |
| src/logo/ascii/xubuntu.txt | Add Xubuntu ASCII logo |
| src/detection/*.sunos.c | Add Solaris/OpenIndiana detection for Sound, BIOS, Disk |
| src/detection/cpuusage/*.{c,windows.c} | Switch to perflib on Win10+, include IRQ/softirq times |
| src/detection/os/os_linux.c | Use ffStrbufSetStatic for static string assignments |
| CMakeLists.txt | Update version to 2.47.0, adjust ENABLE_PULSE/PCIACCESS |
| CHANGELOG.md, debian/*, README.md, ci.yml | Bump versions and document new features/fixes |
Comments suppressed due to low confidence (3)
src/logo/image/image.c:711
- Missing semicolon after macro invocation; this will cause a compile error. Add a trailing
;.
FF_LIBRARY_LOAD_SYMBOL(imData->library, MagickCoreGenesis, FF_LOGO_IMAGE_RESULT_INIT_ERROR)
src/logo/image/im7.c:22
- Macro invocation is missing a semicolon at the end, leading to a syntax error. Append
;.
FF_LIBRARY_LOAD_SYMBOL_ADDRESS(imageMagick, ffResizeImage, ResizeImage, FF_LOGO_IMAGE_RESULT_INIT_ERROR)
src/common/io/io.h:22
- [nitpick] Increasing buffer size impacts stack usage only if declared on stack; since this is static define for heap reads it's acceptable but verify that large reads don't exceed memory constraints in low-memory environments.
#define PROC_FILE_BUFFSIZ (32 * 1024)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.