-
-
Notifications
You must be signed in to change notification settings - Fork 597
Release: v2.48.1 #1852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: v2.48.1 #1852
Conversation
…n different platforms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This is a release PR for version 2.48.1 that introduces conditional module support, improves package manager handling, and fixes cross-platform compatibility issues. The changes include:
- Adding conditional module execution based on system and architecture
- Adding a
combinedoption for package managers to merge related counts - Improving process spawning reliability on Windows and fixing compatibility for Android/OpenBSD
- Adding Openbox WM version detection support
Reviewed Changes
Copilot reviewed 89 out of 89 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Multiple module files | Add support for "condition" key in JSON parsing to enable conditional modules |
| src/modules/packages/* | Add combined package manager option and related logic |
| src/common/jsonconfig.c | Implement conditional module execution logic based on system/arch matching |
| src/common/processing_*.c | Improve process spawning and fix platform compatibility issues |
| src/common/io/* | Add ffGetNullFD function for consistent null file descriptor handling |
| src/detection/wm/wm_linux.c | Add Openbox version detection and refactor common version extraction |
| Version/config files | Update version numbers, changelog, and configuration schemas |
Comments suppressed due to low confidence (1)
src/detection/wm/wm_linux.c:179
- [nitpick] The function name 'extractCommonWmVersion' could be more descriptive. Consider 'extractVersionFromBinary' or 'extractVersionPattern' to better indicate its purpose of extracting version strings matching x.y.z pattern.
static bool extractCommonWmVersion(const char* line, FF_MAYBE_UNUSED uint32_t len, void *userdata)
| FF_PRINT_PACKAGE_NAME(brew, "brew") | ||
| FF_PRINT_PACKAGE_NAME(brewCask, "brew-cask") |
Copilot
AI
Jul 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The macro call is missing a closing brace according to the new macro definition pattern. The FF_PRINT_PACKAGE_NAME macro now uses curly braces but this call doesn't follow the pattern.
| FF_PRINT_PACKAGE_NAME(brew, "brew") | |
| FF_PRINT_PACKAGE_NAME(brewCask, "brew-cask") | |
| FF_PRINT_PACKAGE_NAME({brew, "brew"}) | |
| FF_PRINT_PACKAGE_NAME({brewCask, "brew-cask"}) |
Copilot uses AI. Check for mistakes.
| return "CreateFileW(L\"\\\\.\\pipe\\FASTFETCH-$(PID)\") failed"; | ||
|
|
||
| PROCESS_INFORMATION piProcInfo = {0}; | ||
| PROCESS_INFORMATION piProcInfo = {}; |
Copilot
AI
Jul 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Using empty brace initialization '{}' instead of '{0}' is a C++ style. In C, '{0}' is more conventional and explicitly shows zero-initialization intent.
| PROCESS_INFORMATION piProcInfo = {}; | |
| PROCESS_INFORMATION piProcInfo = {0}; |
Copilot uses AI. Check for mistakes.
No description provided.