fix(detection/terminalshell): use absolute path to shell if available #2067
+9
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnooree
force-pushed
the
fix/detect/termshell
branch
from
8d5ee27 to
eacb22a
Compare
Member
|
Do the same for terminals? |
1 similar comment
Member
|
Do the same for terminals? |
Author
Yes, if you could give me the code location, I can try fixing that too. |
Member
|
Well, you know the file you modified is called |
Author
|
Oh it's in the same file. Wait for me... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes shell executable name (
exe; e.g.,zsh) might resolve to a different path than path to the login shell (exePath; e.g.,/bin/zsh). This PR tries to use absolute path to the login shell if possible, and fallback to previous behavior if absolute path is not available.