Skip to content

Conversation

neothone
Copy link

Fix Translation\Bundle\Tests\Unit\Twig\DefaultApplyingNodeVisitorTest::testApply

Fix Translation\Bundle\Tests\Unit\Twig\DefaultApplyingNodeVisitorTest::testApply
@Copilot Copilot AI review requested due to automatic review settings July 23, 2025 13:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a test in the Translation Bundle by removing deprecated operator attribute setting from Twig's binary expression handling. The change addresses compatibility issues with newer versions of Twig by cleaning up unnecessary operator attribute assignment.

  • Removes deprecated operator attribute setting on binary expressions for Twig 3.17+
  • Eliminates redundant blank line for cleaner code formatting
Comments suppressed due to low confidence (1)

Twig/Visitor/DefaultApplyingNodeVisitor.php:124

  • Good fix - removing the deprecated operator attribute setting. In Twig 3.17+, the operator attribute is automatically set by the EqualBinary constructor and manually setting it is no longer necessary and may cause issues.
            );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant