ci(ci): run benchmarks as part of tests #387
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Failure for Node 22 related to #382? |
Member
|
CI is failing |
Fdawgs
force-pushed
the
Fdawgs-patch-1
branch
2 times, most recently
from
ab0de1c to
5d02101
Compare
Member
Author
|
Unblocked by #382 being merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the absence of unit tests, we should just run the benchmarks (but not commit the results) as part of the CI workflow, to ensure any changes don't break the benchmarks.
Checklist
npm run testandnpm run benchmarkand the Code of conduct