-
-
Notifications
You must be signed in to change notification settings - Fork 77
feat: experimental bun and deno support #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6ef66c6 to
2164d07
Compare
|
Not against it, but I think we don't official support these runtime through the organization right? |
|
Not officially, yes, we're Node first But I think we have an unofficial policy to support other runtimes in a best-effort manner, meaning as long as they don't disrupt anything related to Node (see alternative runtimes job in Fastify, there was some discussion around it with similar conclusions) |
|
Would be cool if there is a review. :) Pinned swc to 1.20 because of |
gurgunday
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Recommend to wait for @fastify/leads feedback. |
Eomm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it mean that fastify support it too?
I would mark it as "experimental" feature in case, where experimental means:
- nodejs has priority
- if a feature does not work on another engine, it does not stop the publishing
|
@Uzlopak Can you please rebase and resolve merge conflicts? I think this is good to go after that! |
Signed-off-by: Aras Abbasi <aras.abbasi@googlemail.com>
|
done |
|
@Eomm |
Eomm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
I would not scream it to the world, but I know you are cooking something 😄
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct