Skip to content

Conversation

@Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Oct 24, 2025

Checklist

@Uzlopak Uzlopak force-pushed the bun-deno branch 2 times, most recently from 6ef66c6 to 2164d07 Compare October 25, 2025 02:29
@jean-michelet
Copy link
Member

Not against it, but I think we don't official support these runtime through the organization right?

@gurgunday
Copy link
Member

Not officially, yes, we're Node first

But I think we have an unofficial policy to support other runtimes in a best-effort manner, meaning as long as they don't disrupt anything related to Node (see alternative runtimes job in Fastify, there was some discussion around it with similar conclusions)

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 25, 2025

@jean-michelet
@gurgunday

Would be cool if there is a review. :)

Pinned swc to 1.20 because of

swc-project/swc#11129

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned swc to 1.20 because of

swc-project/swc#11129

That was my only question actually

lgtm

@jean-michelet
Copy link
Member

Recommend to wait for @fastify/leads feedback.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 25, 2025

In #408 @mcollina approved the corresponding changes.

@Uzlopak Uzlopak mentioned this pull request Oct 25, 2025
2 tasks
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean that fastify support it too?
I would mark it as "experimental" feature in case, where experimental means:

  • nodejs has priority
  • if a feature does not work on another engine, it does not stop the publishing

@Fdawgs
Copy link
Member

Fdawgs commented Dec 4, 2025

@Uzlopak Can you please rebase and resolve merge conflicts? I think this is good to go after that!

Signed-off-by: Aras Abbasi <aras.abbasi@googlemail.com>
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Dec 4, 2025

@Fdawgs

done

@Uzlopak Uzlopak changed the title feat: add bun and deno support feat: experimental bun and deno support Dec 4, 2025
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Dec 4, 2025

@Eomm
I renamed the title and added "experimental". If it is failing for some reason on deno or bun, we are not obligated to "support" it at any cost. If bun or deno workflows fail, we can decide to merge anyway.

Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

I would not scream it to the world, but I know you are cooking something 😄

@Uzlopak Uzlopak merged commit c089ca0 into main Dec 5, 2025
19 checks passed
@ilteoood ilteoood deleted the bun-deno branch January 10, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants