Skip to content

fix(templates): route definition comment line #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(templates): route definition comment line #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/app-esm/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default async function (fastify, opts) {
options: Object.assign({}, opts)
})

// This loads all plugins defined in routes
// This loads all routes defined in routes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole sentence does seem correct: a plugin contains the routes

Maybe we should say "this loads all the plugins defined in routes folder"

// define your routes in one of these
fastify.register(AutoLoad, {
dir: path.join(__dirname, 'routes'),
Expand Down
2 changes: 1 addition & 1 deletion templates/app-ts/src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const app: FastifyPluginAsync<AppOptions> = async (
options: opts
})

// This loads all plugins defined in routes
// This loads all routes defined in routes
// define your routes in one of these
void fastify.register(AutoLoad, {
dir: join(__dirname, 'routes'),
Expand Down
2 changes: 1 addition & 1 deletion templates/app/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ module.exports = async function (fastify, opts) {
options: Object.assign({}, opts)
})

// This loads all plugins defined in routes
// This loads all routes defined in routes
// define your routes in one of these
fastify.register(AutoLoad, {
dir: path.join(__dirname, 'routes'),
Expand Down