feat: implement instanceof

[Uzlopak]

Maybe a solution for #17

[mcollina]

Works for me, LGTM.

Can you document this?

[jsumners]

Does the example in #86 (comment) pass with this?

[Uzlopak]

@mcollina
@jsumners

What do you think about this approach?

[jsumners]

Looks good to me.

[gurgunday]

this approach looks great!

[Uzlopak]

@mcollina
@jsumners
@gurgunday

I added some documentation. Please review again.

[Uzlopak]

@Fdawgs
Can you additionally to a review of the code a review of the documentation please?

[Uzlopak]

@Fdawgs

Thank you very much. I applied your suggestions :).

@jsumners
did you see the changes to the test file?

[gurgunday]

🚀

[Uzlopak]

Should we release it as a major or as a minor?

Could be potentially better to release as major, because it is easier to track that this feature was part of v5 as v4.2.0

[Fdawgs]

Should we release it as a major or as a minor?

Could be potentially better to release as major, because it is easier to track that this feature was part of v5 as v4.2.0

Minor, no breaking changes from what I can see?

[Uzlopak]

Just for support reasons. Like somebody asks, why it doesnt work, and then we just need to say, make npm ls and then we see, that v5 is not used everywhere, so that is the issue. Or else we need to keep in mind, that v4.2.0 is the one with this change.

Thats the only reason, i would say.

[jsumners]

Trying to synchronize major version numbers across all modules to the major version of the framework is a ship that sailed a long time ago. It also introduces too many difficulties (e.g. not being able to ship a major in a module that really needs one). There's a malleable database server that forces its official modules to match the major version of the database, and it results in the modules violating semver guarantees on a routine basis. We should not do the same.

[Uzlopak]

@jsumners

Allright :)

[Uzlopak]

@fastify/core
Should we release it?

[jsumners]

Go for it.

[Uzlopak]

@jsumners

I dont have publish right for npm.

[jsumners]

@Uzlopak please add your npm account to the new discussion I created in the private discussions. Also, since this is a library, you'd need to be on the libraries team. Are you wanting to join that team?