Skip to content

feat: use generic on userinfo #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: use generic on userinfo #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19cd334
feat: use generic on userinfo
Joabesv Jun 28, 2024
546c7d6
add typing test
Uzlopak Nov 21, 2024
292ea97
resolve pr comment
Uzlopak Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,13 +183,13 @@ declare namespace fastifyOauth2 {

revokeAllToken(revokeToken: Token, httpOptions: Object | undefined): Promise<void>;

userinfo(tokenSetOrToken: Token | string): Promise<Object>;
userinfo<TUserInfo = Object>(tokenSetOrToken: Token | string): Promise<TUserInfo>;

userinfo(tokenSetOrToken: Token | string, userInfoExtraOptions: UserInfoExtraOptions | undefined): Promise<Object>;
userinfo<TUserInfo = Object>(tokenSetOrToken: Token | string, userInfoExtraOptions: UserInfoExtraOptions | undefined): Promise<TUserInfo>;

userinfo(tokenSetOrToken: Token | string, callback: (err: any, userinfo: Object) => void): void;
userinfo<TUserInfo = Object>(tokenSetOrToken: Token | string, callback: (err: any, userinfo: TUserInfo) => void): void;

userinfo(tokenSetOrToken: Token | string, userInfoExtraOptions: UserInfoExtraOptions | undefined, callback: (err: any, userinfo: Object) => void): void;
userinfo<TUserInfo = Object>(tokenSetOrToken: Token | string, userInfoExtraOptions: UserInfoExtraOptions | undefined, callback: (err: any, userinfo: TUserInfo) => void): void;
}
export type UserInfoExtraOptions = { method?: 'GET' | 'POST', via?: 'header' | 'body', params?: object };
export const fastifyOauth2: FastifyOauth2
Expand Down
1 change: 1 addition & 0 deletions types/index.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,7 @@ server.get('/testOauth/callback', async (request, reply) => {
expectType<Promise<Object>>(server.testOAuthName.userinfo(token.token));
expectType<Promise<Object>>(server.testOAuthName.userinfo(token.token.access_token));
expectType<Object>(await server.testOAuthName.userinfo(token.token.access_token));
expectType<{a: string}>(await server.testOAuthName.userinfo<{a: string}>(token.token.access_token));
expectType<void>(server.testOAuthName.userinfo(token.token.access_token, () => {}));
expectType<void>(server.testOAuthName.userinfo(token.token.access_token, undefined, () => {}));
expectAssignable<UserInfoExtraOptions>({ method: 'GET', params: {}, via: 'header' });
Expand Down