Renaming things for clarity #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
- Replace .call() pattern with regular function taking single context parameter
- Simplify setup return type from { client, routes } to just ClientModule
- Move hasIterableRoutes type guard to shared mode/support.ts
- Rename SetupFunctionContext -> FastifyViteDecorationPriorToSetup
- Rename mode/types.ts -> mode/support.ts
- Use hasIterableRoutes in index.ts for route iteration
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Extract nested functions from setup() to module-level functions with explicit parameters instead of closure captures, improving readability. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming some internal variables for clarity.