Skip to content

refactor: prefix unused params with underscores #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2024
Merged

refactor: prefix unused params with underscores #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/ignore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ suite
})
.run({ async: true })

internals.reviver = function (key, value) {
internals.reviver = function (_key, value) {
return value
}
6 changes: 3 additions & 3 deletions test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ test('parse', t => {
})

t.test('parses object string (reviver)', t => {
const reviver = (key, value) => {
const reviver = (_key, value) => {
return typeof value === 'number' ? value + 1 : value
}

Expand All @@ -58,7 +58,7 @@ test('parse', t => {

t.test('protoAction', t => {
t.test('sanitizes object string (reviver, options)', t => {
const reviver = (key, value) => {
const reviver = (_key, value) => {
return typeof value === 'number' ? value + 1 : value
}

Expand Down Expand Up @@ -158,7 +158,7 @@ test('parse', t => {

t.test('constructorAction', t => {
t.test('sanitizes object string (reviver, options)', t => {
const reviver = (key, value) => {
const reviver = (_key, value) => {
return typeof value === 'number' ? value + 1 : value
}

Expand Down
Loading