Skip to content

Conversation

@Puppo
Copy link
Contributor

@Puppo Puppo commented Apr 19, 2025

Description

This PR enable the svg optimization during the build phase in CI

Related Issues

Addresses #274

Check List

@Puppo Puppo changed the title build: add SVGO for image optimization and update package dependencies build: add SVGO for image optimization Apr 19, 2025
@Puppo Puppo marked this pull request as ready for review April 19, 2025 10:28
@Fdawgs Fdawgs linked an issue Apr 19, 2025 that may be closed by this pull request
@Fdawgs
Copy link
Member

Fdawgs commented Apr 19, 2025

Thanks for the PR @Puppo, this probably needs to be its own job or workflow similar to this, where it commits the optimized images.

@Puppo
Copy link
Contributor Author

Puppo commented Apr 19, 2025

@Fdawgs, do we want to handle also PNG, JPEG, and other extensions, or just .svg?

@Puppo
Copy link
Contributor Author

Puppo commented Apr 19, 2025

@Fdawgs, as the first implementation, I followed your action, but I added the SVG format using svgo.
We can also try using this action if you prefer.

@Eomm Eomm merged commit 80c9426 into fastify:main May 10, 2025
7 of 8 checks passed
@Puppo Puppo deleted the issue-274-optimize-images branch May 10, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

optimise images

3 participants