Intelligently detect the minimum input size needed#72
Open
bdolman wants to merge 1 commit intofastlane-community:masterfrom
Open
Intelligently detect the minimum input size needed#72bdolman wants to merge 1 commit intofastlane-community:masterfrom
bdolman wants to merge 1 commit intofastlane-community:masterfrom
Conversation
Previously there was a hard-coded check to ensure the input image was at least 1024x1024. But there are often cases where that size of image is not needed (e.g. when adding an alternate iOS app icon which doesn't need a corresponding marketing version) Now the check is done based on the output sizes actually requested. In addition, there is now an "allow_upsampling" flag so that this check can be bypassed entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously there was a hard-coded check to ensure the input image
was at least 1024x1024. But there are often cases where that size
of image is not needed (e.g. when adding an alternate iOS app icon
which doesn't need a corresponding marketing version)
Now the check is done based on the output sizes actually requested.
In addition, there is now an "allow_upsampling" flag so that this
check can be bypassed entirely.