Remove stderr/stdout from delete-*-password calls ([#11])#12
Open
lacostej wants to merge 3 commits intofastlane-community:mainfrom
Open
Remove stderr/stdout from delete-*-password calls ([#11])#12lacostej wants to merge 3 commits intofastlane-community:mainfrom
lacostej wants to merge 3 commits intofastlane-community:mainfrom
Conversation
lacostej
changed the title
Author
|
@joshdholtz something you can look at? |
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change to solve #11. It will hide a bit of information, but users should really use
$?to inquire about the various calls anyway and not depend on stdout/stderr output. The library is in version < 1.0 so I expect it is OK to break this "feature".When it comes to error handling, output control etc, the library should be overhauled anyway. See fastlane/fastlane#11637.