Merged
Conversation
cceckman-at-fastly
force-pushed
the
cceckman/user-metadata
branch
from
5b0f342 to
ef2fea9
Compare
cceckman-at-fastly
force-pushed
the
cceckman/cache-range
branch
3 times, most recently
from
191b54f to
889d6e1
Compare
cceckman-at-fastly
changed the base branch from
cceckman/user-metadata
to
cceckman/cache-length
cceckman-at-fastly
force-pushed
the
cceckman/cache-range
branch
from
889d6e1 to
5f34d05
Compare
cceckman-at-fastly
force-pushed
the
cceckman/cache-length
branch
from
354a425 to
81869a2
Compare
cceckman-at-fastly
force-pushed
the
cceckman/cache-range
branch
from
5f34d05 to
474c7ce
Compare
cceckman-at-fastly
force-pushed
the
cceckman/cache-range
branch
from
474c7ce to
b872734
Compare
Contributor
Author
|
@aturon and I discussed this today. While this accurately represents what Compute Platform does... this is a bad behavior and we don't want to support it. We have a strategy to roll out a fix that gives the sensible behavior for |
cceckman-at-fastly
force-pushed
the
cceckman/cache-range
branch
3 times, most recently
from
c68bed8 to
5274dd5
Compare
cceckman-at-fastly
force-pushed
the
cceckman/cache-range
branch
from
5274dd5 to
5155757
Compare
In the most recent builds of the compute platform, get_body can block until the start of the requested range is available (if the always_use_requested_range flag is set). Prepare for this by making get_body async, using a named `impl Future` that can hold the range-related options.
Allow `read_range` in CollectingBody with a start (and optional end) offset. Add helpers to allow waiting for a known or minimum length, which we need to get a consistent blocking behavior with Compute. Add the proptest regressions files for body and collecting_body.
cceckman-at-fastly
force-pushed
the
cceckman/cache-range
branch
from
5155757 to
a00e4ca
Compare
aturon
approved these changes
Jul 16, 2025
Contributor
aturon
left a comment
aturon
left a comment
There was a problem hiding this comment.
Fabulous work! Greatly appreciate the clarity of the code given how gnarly the matrix of possible situations is 👏👏👏
I've read over quite carefully, and don't see anything that needs further refinement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support range requests in the cache API. This completes options processing for the core cache API.
According to the tests, this matches the
always_use_requested_rangebehavior of the Compute platform.