Update adapter with the memory shift fix#538
Merged
chenyan2002 merged 2 commits intomainfrom Oct 6, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagating changes from https://github.com/fastly/ExecuteD/pull/5528.
The adapter module takes a fixed two pages of memory. It gets this memory either via cabi_realloc exported from the main module or memory.grow at the beginning of the component instantiation. The is not a safe assumption for managed languages like Go or Python.
This PR avoids this problem by rewriting the main module to always access the memory with a 2 page offset. In this way, the first two pages of the memory is never touched by the main module. Then the adapter can safely write its state and stack to the first two pages without corrupting user memory.