Return 5XX for requests that land in a reused session that crashes#540
Merged
Return 5XX for requests that land in a reused session that crashes#540
Conversation
acw
approved these changes
Oct 7, 2025
Contributor
acw
left a comment
There was a problem hiding this comment.
Seems fine, although I have one question about a panic.
| anyhow_response(e) | ||
| } else { | ||
| resp | ||
| panic!("failed to run guest: {err}") |
Contributor
There was a problem hiding this comment.
Why panic here, rather than turning the execution error into an anyhow response?
Contributor
Author
There was a problem hiding this comment.
I'm doing this to continue matching the behaviour from here:
Lines 592 to 606 in f2ea186
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the logic for turning an error into a 500 response to happen right after the guest crashes by calling
Session::close_downstream_response_senderso that it will still apply to reused sessions. Fortunately, the ways that a guest can exit here are much simpler than in Compute, so this ends up being a simpler change.