Fix manual framing incorrectly falling back to automatic mode#571
Merged
franfastly merged 2 commits intofastly:mainfrom Jan 16, 2026
Merged
Fix manual framing incorrectly falling back to automatic mode#571franfastly merged 2 commits intofastly:mainfrom
franfastly merged 2 commits intofastly:mainfrom
Conversation
franfastly
reviewed
Jan 14, 2026
Contributor
franfastly
left a comment
franfastly
left a comment
There was a problem hiding this comment.
Thank you for working on this! Your fix looks great to me. I only have a comment regarding the integration test
When using manual framing with only a content-length or transfer encoding header set, viceroy was falling back to auto mode
franfastly
reviewed
Jan 15, 2026
Contributor
franfastly
left a comment
franfastly
left a comment
There was a problem hiding this comment.
Looking good! There's only a few minor things left
Contributor
Author
|
Thanks @franfastly, have updated comments & test name |
franfastly
approved these changes
Jan 16, 2026
Contributor
franfastly
left a comment
franfastly
left a comment
There was a problem hiding this comment.
Code looks good to me and tests pass. Thank you again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using manual framing with only a content-length header set, viceroy was falling back to auto mode.
This attempts to address #570