refactor: Use constants from net/http for HTTP methods instead of hardcoded strings.#1376
Merged
kpfleming merged 2 commits intofastly:mainfrom Jan 23, 2025
Merged
Conversation
Integralist
approved these changes
Jan 22, 2025
Contributor
|
Thanks for the PR! I'll be investigating the CI failure tomorrow, it's not related to this PR and it doesn't happen in a local build... |
kpfleming
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
Updated occurrences of HTTP methods (e.g., "GET", "POST") with their corresponding constants from the net/http package (e.g., http.MethodGet, http.MethodPost).
Ensures consistency, improves maintainability, and reduces the risk of typos.
Using constants improves code readability and reduces the risk of errors from hardcoded values.
executed
make alland the output is same as asmainbranch