Dockerfile-rust: use base image toolchain instead of reinstalling stable#1654
Merged
anthony-gomez-fastly merged 1 commit intofastly:mainfrom Feb 20, 2026
Merged
Conversation
backkem
force-pushed
the
rust-dockerfile
branch
from
2be4651 to
9f38859
Compare
backkem
force-pushed
the
rust-dockerfile
branch
from
9f38859 to
a8a2cf1
Compare
backkem
force-pushed
the
rust-dockerfile
branch
from
a8a2cf1 to
7d3f465
Compare
|
LGTM. Serious regressions in the WebAssembly target have occurred a couple of times in Rust releases, so pinning tested versions is a prudent approach. |
anthony-gomez-fastly
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
rustup toolchain install stablere-downloads the latest stable toolchain,which may differ from the pinned
rust:base image version. This seemsredundant and is somewhat non-obvious if you want to pin the Rust version.
(e.g. when pinning Rust 1.92 since the current latest CLI panics with stable:
"version '1.93.1' of Rust has not been validated for use with Fastly Compute.").
Since the base image already ships with the correct toolchain, just add
the wasm target directly.
All Submissions:
same update/change?
User Impact
None — only affects the Docker build image, not the CLI itself.
Are there any considerations that need to be addressed for release?
No. Technically this Dockerfile still fails to run CLI v13.3.0 unless you pin the Rust version. This at least centralizes the latter.