Skip to content

fsthttp: ensure OverrideKey has the correct format #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
Merged

fsthttp: ensure OverrideKey has the correct format #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions fsthttp/request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package fsthttp
import (
"bytes"
"context"
"encoding/hex"
"errors"
"fmt"
"io"
Expand Down Expand Up @@ -516,6 +517,9 @@ func (req *Request) sendWithGuestCache(ctx context.Context, backend string) (*Re

var options fastly.HTTPCacheLookupOptions
if key := req.CacheOptions.OverrideKey; key != "" {
if len(key) != 32 {
return nil, fmt.Errorf("bad length for OverrideKey: %v != 32", len(key))
}
options.OverrideKey(key)
req.CacheOptions.OverrideKey = ""
}
Expand Down Expand Up @@ -841,6 +845,13 @@ func (req *Request) setABIRequestOptions() error {
}

if key := req.CacheOptions.OverrideKey; key != "" {
if len(key) != 32 {
return fmt.Errorf("bad length for OverrideKey: %v != 32", len(key))
}

// the header must be 64-byte upper-case hex encoded
key = strings.ToUpper(hex.EncodeToString([]byte(key)))

if err := abiReq.SetHeaderValues("fastly-xqd-cache-key", []string{key}); err != nil {
return fmt.Errorf("set headers cache-key: %w", err)
}
Expand Down