Omit empty cursor parameter in Compute ACL's ListEntries requests#778
Merged
philippschulte merged 1 commit intofastly:mainfrom Jan 21, 2026
Conversation
kpfleming
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
This PR fixes an issue where the
go-fastlyclient would send a?cursor=query parameter inListEntriesrequests when no cursor value was provided by the user.Recent upstream API behavior now rejects this with a
400 Bad Request: invalid cursorerror. Previously, this was either tolerated by the API or untested — but we cannot definitively prove whether the behavior changed or was always like this.Root cause
go-fastly) setsCursor = ""by default when the--cursorflag is not provided, due to Go’s default zero value for strings.go-fastly, theListEntriesfunction would include all non-nil values in the query parameters — socursor=""resulted in a request like:cursoris documented as optional.Fix
We now explicitly omit the
cursorparameter from the request if:nil, or"")This matches the intended behavior and prevents accidental inclusion of invalid
cursorvalues.Test coverage
TestClient_ComputeACL) to verify that callingListEntrieswithcursor=""does not result in an error.All Submissions: