Handle UNINITIALIZED and OK KV store errors
#1278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
make_fastly_kv_errordoesn't handle theKV_ERROR_OKorKV_ERROR_UNINITIALIZEDvariants, which can happen if the hostcall fails in several unplanned ways, in which case it will return a correspondingFastlyStatus. It looks like theswitchstatement meant to usehost_errorin those cases, but thedefault:branch makes aninternal_errorinstead.I've updated the function to create a
host_errorand track theFastlyStatusvalue, which should make sure we hit this path and get the relevant status:js-compute-runtime/runtime/fastly/host-api/host_call.cpp
Lines 39 to 42 in 363550a