replace qzmq namespace with zmq prefix#48266
Merged
Conversation
clintjedwards
approved these changes
Sep 12, 2025
serra-fastly
pushed a commit
that referenced
this pull request
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the classes in the QZmq namespace no longer use Qt, we should drop the "Q" from the name. Since Pushpin doesn't normally use namespaces around classes, this PR removes the namespace instead of renaming it, and prefixes all its classes with
Zmq. This flat approach is more consistent with the rest of the C++ code. The reason there was a namespace to begin with is QZmq was originally a separate library.Despite this change, I'm not against developing a namespace structure for the C++ code, especially since our Rust code is organized into modules. This PR is just to make things consistent in the meantime.