proxy/handler: reorganize program startup a little bit#48267
Merged
Conversation
clintjedwards
approved these changes
Sep 23, 2025
serra-fastly
pushed a commit
that referenced
this pull request
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tweaks a few organizational bits around proxy and handler startup:
{proxy,handler}_mainare renamed to{proxy,handler}_init, to clarify they don't take argc + argv.{proxy,handler}cliargsare renamed tocliargssince they are already scoped by program module.app.cppandengine.{h,cpp}are renamed toproxyapp.cppandproxyengine.{h,cpp}, respectively, for consistency with the naming of handler files.main.cpp(for proxy) andhandlermain.cppare moved into{proxy|handler}app.cpp, respectively, and the files are removed. Relatedly,app.h(for proxy) andhandlerapp.hare removed.For background, the reason we have some program-prefixed filenames despite the files living in different directories, such as
src/proxy/proxyapp.cppandsrc/handler/handlerapp.cppinstead of more simplysrc/proxy/app.cppandsrc/handler/app.cpp, is because qmake requires all files in the project to have unique names regardless of directory. If we ever find a way to overcome that limitation, we could remove these prefixes.