handler: run event loop within executor#48279
Merged
Conversation
4971d5e to
19549c3
Compare
19549c3 to
407f647
Compare
clintjedwards
approved these changes
Oct 29, 2025
serra-fastly
pushed a commit
that referenced
this pull request
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the necessary APIs have been made available to the C++ code, we can run an
EventLoopthat executes asynchronously within a task spawned on anExecutor. We'll start out by doing this in the handler.Moving the existing straight-line logic into the
setupanddoneclosures is a little tricky regarding lifetimes. The closures borrow, so we need to make sure theloop,deferCall, andenginebindings all live outside them, and we need to ensure correct construction/destruction ordering. Notably,DeferCallmust not be constructed until after anEventLoopexists (i.e. aftersetupcalled), and it needs to be destructed before theEventLoopgoes away (i.e. beforedoneends).