Depthwise convolution for oneAPI#1131
Merged
JanFSchulte merged 129 commits intofastmachinelearning:mainfrom Dec 18, 2024
Merged
Depthwise convolution for oneAPI#1131JanFSchulte merged 129 commits intofastmachinelearning:mainfrom
JanFSchulte merged 129 commits intofastmachinelearning:mainfrom
Conversation
Contributor
|
Is it worth adding 1D versions, too? |
Contributor
|
Why so many commits? Is it worth rebasing on a new branch from main? |
jmitrevs
requested changes
Nov 18, 2024
hls4ml/templates/oneapi/firmware/nnet_utils/nnet_depthconv2d_resource.h
Outdated
Show resolved
Hide resolved
hls4ml/templates/oneapi/firmware/nnet_utils/nnet_depthconv2d_resource.h
Outdated
Show resolved
Hide resolved
jmitrevs
requested changes
Nov 20, 2024
hls4ml/templates/oneapi/firmware/nnet_utils/nnet_depthconv2d_resource.h
Outdated
Show resolved
Hide resolved
jmitrevs
approved these changes
Dec 17, 2024
Contributor
|
Will this really add 129 new commits, or is this just some confusion? Might be good to squash the commits to prevent that. |
Contributor
|
It should be squashed. |
Contributor
|
The squashing would be when we merge the PR, by selecting squash and merge, right? There's no need to manually squash the commits. |
Contributor
|
Ah, yes. I was looking for a squash button yesterday, didn't realize it was in the drop down next to the green button. I'll merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Adding Depthwise convolution in a parallel implementation. Supports depth multiplier. When a separable convolution layer is used, it is split to depthwise and pointwise layers.
Note: Please delete options that are not relevant.
Tests
Test Configuration:
Checklist
pre-commiton the files I edited or added.