Update install_requires for 1.0.0#1136
Merged
bo3z merged 2 commits intofastmachinelearning:mainfrom Nov 23, 2024
Merged
Conversation
bo3z
approved these changes
Nov 23, 2024
Contributor
|
Looks good to me, just tested locally and it worked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current hls4ml won't install properly on an empty environment as this will pull TF 2.18 and keras v3 which are not compatible. We mention in the docs the supported versions of TF are between 2.8 and 2.14, but this was not enforced. Due to the restriction of TF 2.14 not working on python 3.12, we can only support python 3.10 and 3.11. Furthermore QKeras installation pulls version 0.9.0 which is not supported anymore. This was changed to the git version (we can put our own version if needed).
In the future once we move to a more modular base (beginnings of which are in #1094) we should also move to pyproject.toml for managing dependencies.
Type of change
Tests
Only concerns the environments. Shouldn't break existing test pipeline.
Checklist
yeah, yeah, I've done all of this.