Don't overwrite already set accum_t, fix pointwise output resolution#1146
Merged
JanFSchulte merged 3 commits intomainfrom Dec 14, 2024
Merged
Don't overwrite already set accum_t, fix pointwise output resolution#1146JanFSchulte merged 3 commits intomainfrom
JanFSchulte merged 3 commits intomainfrom
Conversation
Contributor
Author
|
This needs fastmachinelearning/example-models#19 to be merged. |
Contributor
Author
|
With the updated example-models, and existing test ( |
JanFSchulte
approved these changes
Dec 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modify
Layer._set_accum_t()to not overwrite an already existingaccum_t, which can happen in an optimizer. Also, modify the pointwise init functions to do nothing, since the values are already set. Otherwise, the result_t was overwritten, potentially nullifying an explicit value set by a quantizer (a Quant node in a failing test).Type of change
Tests
The failing test that this fixes will be added soon. It is important that it doesn't break anything else.
TODO: We should confirm that there are no other optimizers that may cause the same probelm
Checklist
pre-commiton the files I edited or added.