oneAPI 2025.0 include changes#1149
Merged
bo3z merged 4 commits intofastmachinelearning:mainfrom Jan 14, 2025
Merged
Conversation
Contributor
|
Changing this to draft till we update our test environment. |
bo3z
requested changes
Jan 10, 2025
Contributor
bo3z
left a comment
bo3z
left a comment
There was a problem hiding this comment.
We can merge this but I would like to confirm this indeed works with oneAPI < 2025.0. If not, there should be an #ifdef checking for the version.
Contributor
|
Pytests have passed, so I guess this change is save an can be merged now? |
Contributor
|
The pytest wouldn't catch the failure since it's in the _test file. Lauri will add ifdefs, he said. |
Contributor
|
Ah, I misunderstood. Great news about ifdefs. |
JanFSchulte
approved these changes
Jan 13, 2025
JanFSchulte
added
please test
bo3z
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing include for 2025.0
Type of change
oneAPI 2025.0 removes
interfaces.hppand the relevant functions are available fromfpga_extensions.hppChecklist
pre-commiton the files I edited or added.