remove test skip since problem fixed in qonnx#1152
Merged
bo3z merged 2 commits intofastmachinelearning:mainfrom Mar 7, 2025
Merged
remove test skip since problem fixed in qonnx#1152bo3z merged 2 commits intofastmachinelearning:mainfrom
bo3z merged 2 commits intofastmachinelearning:mainfrom
Conversation
bo3z
reviewed
Jan 10, 2025
Contributor
bo3z
left a comment
There was a problem hiding this comment.
This looks good to me, can we create a new Docker image and run the tests, so this can be merged?
Contributor
Author
|
This depends on #1200. After that goes in, this should be able to go in (though it should be confirmed). |
JanFSchulte
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There currently is one test that is skipped because the qonnx channels-last conversion fails with it. Wit the current head of qonnx, this is no longer the case, so we no longer need to skip the test. However, we need to update our test environment first, so this is created as a draft at the moment
Type of change
[x] Other (Specify) Stop skipping a test
Tests
The pytests should all pass after we create a new testing container.
Checklist
pre-commiton the files I edited or added.