-
Notifications
You must be signed in to change notification settings - Fork 509
Add keras3 environment in tests #1412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Looks good so far. What's the error with pytest 9, did the fixture API change? Will we have to change all tests to support that? |
|
Pytest 9 turns the existing |
|
@vloncar @marco66colombo I just ran into this issue when I recreated my test environment and ended up with pytest 9. #1417 makes the necessary changes, so if we decide to merge that, we could migrate the test environments to use pytest 9 as well. |
|
About the qonnx version and compatibility, we will probably have to deal with it soon, but if things work as they are in this PR, I fine with it. Generally things look good to me, so if the tests all succeed, I'll resolve the coversations and approve the PR. |
Description
0.6.3.base(Py3.12, Keras3) and keep the default pytest jobs on the Keras2 env.generate_ci_yaml.pyso that Keras3-only tests run in a separate Keras3 job. Other tests stay batched on Keras2 env. Keras3-only set for:test_keras_v3_api.py,test_hgq2_mha.py,test_einsum_dense.py,test_qeinsum.py.parallelization_factorkwarg).Note: pinned
pytest<9in testing extras to avoid pytest 9 hard error on marks applied to fixtures (existing tests still use that pattern).Future work: decide which tests to port to Keras3 vs. keep on Keras2 vs. run on both, and track hgq2/Keras3 compatibility for MHA.
Type of change
Tests
Checklist
pre-commiton the files I edited or added.