wip: ft_sdk::Required handles body better #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddhantk232
reviewed
Jun 9, 2025
ft-sdk/src/from_request/required.rs
Outdated
Comment on lines
80
to
82
| if let serde_json::Value::String(s) = value { | ||
| return Ok(serde_json::from_str(s).map(Required)?); | ||
| } |
Contributor
There was a problem hiding this comment.
Even tho this code path is interesting and we should keep it. This is not hit when running inside lets-teach code. I am going to remove redundant println! from this PR and we can merge this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart of fastn-stack/fastn#2140.