Skip to content

fix: add mobile Safari safe area support #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ComputelessComputer wants to merge 2 commits into from
Closed

fix: add mobile Safari safe area support #2135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34744c3
fix: add mobile Safari safe area support
devin-ai-integration[bot] Dec 5, 2025
71e340f
Merge main into devin/1764920268-fix-mobile-safari-safe-area
devin-ai-integration[bot] Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/web/src/components/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,10 @@ function MobileMenu({
className="fixed inset-0 z-40 sm:hidden"
onClick={() => setIsMenuOpen(false)}
/>
<div className="fixed top-[69px] left-0 right-0 bg-white/80 backdrop-blur-sm border-b border-neutral-100 shadow-[0_4px_6px_-1px_rgba(0,0,0,0.1),0_2px_4px_-2px_rgba(0,0,0,0.1)] z-50 sm:hidden animate-in slide-in-from-top duration-300 max-h-[calc(100vh-69px)] overflow-y-auto">
<div
className="fixed top-[69px] left-0 right-0 bg-white/80 backdrop-blur-sm border-b border-neutral-100 shadow-[0_4px_6px_-1px_rgba(0,0,0,0.1),0_2px_4px_-2px_rgba(0,0,0,0.1)] z-50 sm:hidden animate-in slide-in-from-top duration-300 max-h-[calc(100vh-69px)] overflow-y-auto"
style={{ paddingBottom: "env(safe-area-inset-bottom)" }}
>
<nav className={`${maxWidthClass} mx-auto px-4 py-6`}>
<div className="space-y-6">
<MobileMenuLinks
Expand Down
5 changes: 4 additions & 1 deletion apps/web/src/routes/__root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ export const Route = createRootRouteWithContext<RouterContext>()({
head: () => ({
meta: [
{ charSet: "utf-8" },
{ name: "viewport", content: "width=device-width, initial-scale=1" },
{
name: "viewport",
content: "width=device-width, initial-scale=1, viewport-fit=cover",
},
{ title: TITLE },
{ name: "description", content: DESCRIPTION },
{ name: "keywords", content: KEYWORDS },
Expand Down
2 changes: 2 additions & 0 deletions apps/web/src/routes/_view/route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ function MobileDocsDrawer({
}`}
style={{
paddingLeft: "env(safe-area-inset-left)",
paddingBottom: "env(safe-area-inset-bottom)",
}}
>
<div
Expand Down Expand Up @@ -189,6 +190,7 @@ function MobileHandbookDrawer({
}`}
style={{
paddingLeft: "env(safe-area-inset-left)",
paddingBottom: "env(safe-area-inset-bottom)",
}}
>
<div
Expand Down