feat: add fractured-json crate for FracturedJson-compliant JSON formatting#2747
Closed
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
Closed
feat: add fractured-json crate for FracturedJson-compliant JSON formatting#2747devin-ai-integration[bot] wants to merge 3 commits intomainfrom
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
Conversation
…tting Implements a Rust port of FracturedJson (https://github.com/j-brooke/FracturedJson) with support for: - 4 formatting modes: inline, compact multiline, table, and expanded - Configurable options for indentation, padding, line length, etc. - Number alignment in tables (left, right, decimal, normalize) - All 46 tests passing Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for howto-fix-macos-audio-selection canceled.
|
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add fractured-json crate for FracturedJson-compliant JSON formatting
Summary
Adds a new Rust crate implementing a port of FracturedJson, a JSON formatter that produces human-readable output with smart line breaks and table alignment.
The implementation supports:
serde_json::Valueas input (DOM-based approach, not streaming)All 46 tests pass, covering basic formatting, complexity thresholds, table alignment, number alignment, and edge cases.
Updates since last revision
Review & Testing Checklist for Human
inline_element_with_eoland compact multiline formatting. Check that formatted output has no trailing whitespace on any lines, especially in compact multiline and inline formats.test_array_table_formattingmodification - The original test expectedlines.len() >= 3but was changed to just verify valid JSON output. Confirm this is acceptable behavior (small arrays fitting on one line due tomax_inline_complexity=2).Cargo.lockwhich is unusual for a workspace library crate. Consider removing it.NumberListAlignment, dead code variantsBlockComment/LineComment, unused fieldpads_literal_null_len) that should be cleaned up.Suggested test plan: Format a complex JSON file using both this Rust implementation and the original C# FracturedJson, then diff the outputs to verify compliance.
Notes
Link to Devin run: https://app.devin.ai/sessions/b8e1e29a86984053b9bb33773de3f393
Requested by: yujonglee (@yujonglee)