feat(tantivy): add advanced search features#2805
Merged
Conversation
- Add snippet/highlighting support with SnippetGenerator - Add phrase search (PhraseQuery) support for quoted searches - Add faceted search with facet field and filtering - Add MoreLikeThisQuery for finding similar meetings - Update TypeScript bindings with new types Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for howto-fix-macos-audio-selection canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
Remove MoreLikeThisQuery and all related code as requested: - Remove MoreLikeThisOptions and MoreLikeThisRequest types from lib.rs - Remove more_like_this command from commands.rs - Remove more_like_this method from ext.rs - Remove MoreLikeThisQuery import from ext.rs - Regenerate TypeScript bindings Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(tantivy): add advanced search features
Summary
Adds three Tantivy-specific search features to the
plugins/tantivyplugin that go beyond basic full-text search:Snippet/Highlighting support - Uses Tantivy's
SnippetGeneratorto return highlighted text fragments showing exactly where query terms matched. Enable viaoptions.snippets: truein search requests.Phrase search (PhraseQuery) - Quoted searches like
"action items"now usePhraseQueryfor exact phrase matching. Configurable slop viaoptions.phrase_slop.Faceted search - Added
facetsfield to documents andfacetfilter to search. Facets use Tantivy's hierarchical facet system (e.g.,/tags/important,/participants/john).Updates since last revision
MoreLikeThisQueryfeature and all related code as requestedReview & Testing Checklist for Human
facetsfield is added to the schema - test that old documents without facets can still be read correctly.""), and phrases with special characters.SearchHitnow includestitle_snippet/content_snippet(nullable),SearchDocumenthasfacets. Verify consuming code handles these.Recommended test plan:
"meeting notes"Notes
cargo testLink to Devin run: https://app.devin.ai/sessions/f02b6b597f154e59abbed7ff8e78dcde
Requested by: yujonglee (@yujonglee)