Skip to content

feat: add app icon chooser in settings#3938

Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin/1770950076-app-icon-chooser
Open

feat: add app icon chooser in settings#3938
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin/1770950076-app-icon-chooser

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Feb 13, 2026

feat: add app icon chooser in settings

Summary

Re-introduces the app icon chooser that allows users to switch the dock icon between stable, nightly, staging, and pro variants. The feature was previously implemented and then removed. This wires up the existing @hypr/plugin-icon Rust plugin (which already supports setDockIcon/resetDockIcon) to a new UI in the general settings page.

Changes:

  • New AppIconSettings component with a 4-column grid of icon previews
  • Icon preview PNGs copied from src-tauri/icons/{name}/icon.png into frontend assets
  • app_icon field added to the store schema (zod + TinyBase settings mapping)
  • Config registry entry with side effect that calls the icon plugin on change
  • Wired into the settings form between Transcription and Storage sections

Review & Testing Checklist for Human

  • Test on macOS that clicking each icon option actually changes the dock icon — this is macOS-only (#[cfg(target_os = "macos")]) and could not be verified in this environment
  • Decide if all 4 icons should be visible to all users — the previous implementation (commit b02ea44d4) had tier-based restrictions (nightly-only for nightly builds, pro gets all icons, free stable gets dark/light). This PR shows all icons to everyone. Adjust if needed.
  • No "reset to default" option — once a user selects an icon there is no way to unset it back to undefined. Consider whether a default/reset button is needed.
  • Selection styling uses hardcoded border-blue-500 bg-blue-50 — verify this matches the app's design tokens/theme

Notes


Open with Devin

Co-Authored-By: john@hyprnote.com <john@hyprnote.com>
@netlify
Copy link

netlify bot commented Feb 13, 2026

Deploy Preview for hyprnote canceled.

Name Link
🔨 Latest commit 6404449
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/698e905c696aa7000870e3b4

@netlify
Copy link

netlify bot commented Feb 13, 2026

Deploy Preview for hyprnote-storybook canceled.

Name Link
🔨 Latest commit 6404449
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/698e905c25996800083321ab

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Contributor Author

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant