feat: add app icon chooser in settings#3938
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
feat: add app icon chooser in settings#3938devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: john@hyprnote.com <john@hyprnote.com>
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add app icon chooser in settings
Summary
Re-introduces the app icon chooser that allows users to switch the dock icon between stable, nightly, staging, and pro variants. The feature was previously implemented and then removed. This wires up the existing
@hypr/plugin-iconRust plugin (which already supportssetDockIcon/resetDockIcon) to a new UI in the general settings page.Changes:
AppIconSettingscomponent with a 4-column grid of icon previewssrc-tauri/icons/{name}/icon.pnginto frontend assetsapp_iconfield added to the store schema (zod + TinyBase settings mapping)Review & Testing Checklist for Human
#[cfg(target_os = "macos")]) and could not be verified in this environmentb02ea44d4) had tier-based restrictions (nightly-only for nightly builds, pro gets all icons, free stable gets dark/light). This PR shows all icons to everyone. Adjust if needed.undefined. Consider whether a default/reset button is needed.border-blue-500 bg-blue-50— verify this matches the app's design tokens/themeNotes
.icnsresources already existed; this PR only adds the frontend UI and settings persistence