feat: add template validation using askama_parser#3940
Merged
Conversation
- Add extract() to askama-utils: parses template strings and collects variables and filters from the AST - Add validate() to template-app: validates templates against allowed variables and custom filters (current_date, language, is_english, is_korean) - Add askama_parser as workspace dependency Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add runtime template parsing and validation using
askama_parser.Changes
crates/askama-utils
extract(src)— Parses a template string and walks the AST to collect all referenced variables and filter namesTemplateUsage— Struct withvariablesandfiltersHashSetsaskama_parserdependencycrates/template-app
validate(src, allowed_variables)— Validates that a template only uses allowed variables and the 4 custom filters (current_date,language,is_english,is_korean)ValidationError— Containsunknown_variablesandunknown_filtersfor error reportingErrorenum withParseErrorandValidationErrorvariantsUsage