Skip to content

Conversation

@yujonglee
Copy link
Contributor

@yujonglee yujonglee commented Dec 5, 2025

Summary

Adds @wdio/globals as an explicit devDependency to fix the desktop-e2e-linux CI job failure. The test file apps/desktop-e2e/test/app.spec.js imports { browser, expect } from @wdio/globals, but this package wasn't declared in the package.json. In pnpm's strict dependency model, packages must be explicitly declared to be importable, even if they exist as transitive dependencies.

The version (8.40.6) matches the other @wdio packages in the project.

Review & Testing Checklist for Human

  • Verify the desktop-e2e-linux CI job passes after this change
  • Confirm the lockfile changes are just pnpm reorganizing transitive dependencies (jiti version resolution normalization) and not unexpected additions

Test plan: Trigger the desktop CD workflow with the staging channel and verify the build-linux job completes successfully, particularly the E2E test step.

Notes

@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@netlify
Copy link

netlify bot commented Dec 5, 2025

Deploy Preview for hyprnote ready!

Name Link
🔨 Latest commit 5256d4e
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/693293f234eefc0008dc89c2
😎 Deploy Preview https://deploy-preview-2139--hyprnote.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 5, 2025

Deploy Preview for hyprnote-storybook ready!

Name Link
🔨 Latest commit 5256d4e
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/693293f2c0e0d7000881ea01
😎 Deploy Preview https://deploy-preview-2139--hyprnote-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 5, 2025

📝 Walkthrough

Walkthrough

A new WebdriverIO globals package dependency (version 8.40.6) was added to the desktop end-to-end testing configuration. This is a straightforward dependency addition to the development dependencies section of the test suite package configuration.

Changes

Cohort / File(s) Summary
Test dependency addition
apps/desktop-e2e/package.json
Added @wdio/globals devDependency version 8.40.6

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and accurately describes the main change: adding @wdio/globals dependency to fix test imports in the desktop-e2e package.
Description check ✅ Passed The description is directly related to the changeset, providing clear context about why the dependency was added and its purpose in fixing CI failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devin/1764921414-fix-wdio-globals

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a85a87b and 5256d4e.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • apps/desktop-e2e/package.json (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: fastrepl/hyprnote PR: 0
File: apps/desktop-e2e/AGENTS.md:0-0
Timestamp: 2025-11-24T16:32:24.348Z
Learning: Applies to apps/desktop-e2e/**/*.{test,spec}.{js,ts,tsx} : Refer to `scripts/setup-desktop-e2e.sh` for end-to-end test environment setup if setup is missing
📚 Learning: 2025-11-24T16:32:24.348Z
Learnt from: CR
Repo: fastrepl/hyprnote PR: 0
File: apps/desktop-e2e/AGENTS.md:0-0
Timestamp: 2025-11-24T16:32:24.348Z
Learning: Applies to apps/desktop-e2e/**/*.{test,spec}.{js,ts,tsx} : Refer to `scripts/setup-desktop-e2e.sh` for end-to-end test environment setup if setup is missing

Applied to files:

  • apps/desktop-e2e/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Redirect rules - hyprnote
  • GitHub Check: Header rules - hyprnote
  • GitHub Check: Pages changed - hyprnote
  • GitHub Check: Devin
  • GitHub Check: fmt
🔇 Additional comments (1)
apps/desktop-e2e/package.json (1)

13-13: Dependency addition is consistent and well‑placed.

The @wdio/globals package is added at version 8.40.6, matching all other WebdriverIO packages in the file. Placement in devDependencies is correct, alphabetical ordering is maintained, and the package is actively imported in test files (apps/desktop-e2e/test/app.spec.js).


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yujonglee yujonglee merged commit 775c138 into main Dec 5, 2025
12 of 13 checks passed
@yujonglee yujonglee deleted the devin/1764921414-fix-wdio-globals branch December 5, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants