-
Notifications
You must be signed in to change notification settings - Fork 467
fix(desktop-e2e): add @wdio/globals dependency for test imports #2139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: yujonglee <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughA new WebdriverIO globals package dependency (version 8.40.6) was added to the desktop end-to-end testing configuration. This is a straightforward dependency addition to the development dependencies section of the test suite package configuration. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-11-24T16:32:24.348ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Adds
@wdio/globalsas an explicit devDependency to fix thedesktop-e2e-linuxCI job failure. The test fileapps/desktop-e2e/test/app.spec.jsimports{ browser, expect }from@wdio/globals, but this package wasn't declared in the package.json. In pnpm's strict dependency model, packages must be explicitly declared to be importable, even if they exist as transitive dependencies.The version (8.40.6) matches the other @wdio packages in the project.
Review & Testing Checklist for Human
desktop-e2e-linuxCI job passes after this changeTest plan: Trigger the desktop CD workflow with the staging channel and verify the
build-linuxjob completes successfully, particularly the E2E test step.Notes