fix(web): preserve scroll position in press-kit app sidebar #2141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Preserves the scroll position in the press-kit app sidebar when switching between screenshots. Previously, clicking on a different screenshot would reset the sidebar scroll position to the top.
The fix uses two refs:
scrollRef- attached to the scrollable sidebar containerscrollPosRef- stores the current scroll positionA
useEffecthook restores the scroll position and sets up a scroll listener whenever the selected item changes.Review & Testing Checklist for Human
/press-kit/app, scroll down in the sidebar, click different screenshots, and verify scroll position is preservedNotes
AppDetailView→AppSidebar) has scroll preservation. The mobile drawer (MobileSidebarDrawer) does not have this feature - let me know if it should be added.Requested by: [email protected] (@ComputelessComputer)
Link to Devin run: https://app.devin.ai/sessions/cab0a37e9b8e44c29048b73e72dd05fc