Remove pagefind plugin from hyprnote #2768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove plugins/pagefind directory - Remove pagefind dependency from root Cargo.toml - Remove pagefind dependency from desktop app Cargo.toml - Remove pagefind plugin initialization from lib.rs - Remove pagefind permission from capabilities/default.json - Remove @hypr/plugin-pagefind from desktop package.json Co-Authored-By: yujonglee <[email protected]>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for howto-fix-macos-audio-selection ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-Authored-By: yujonglee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove pagefind plugin from hyprnote
Summary
Removes the
tauri-plugin-pagefindTauri plugin from the desktop application. This includes deleting the entire plugin directory and cleaning up all references across the codebase.Changes:
plugins/pagefind/directory (Rust code, TypeScript bindings, benchmarks, permissions)Cargo.tomlapps/desktop/src-tauri/Cargo.tomlapps/desktop/src-tauri/src/lib.rsapps/desktop/src-tauri/capabilities/default.json@hypr/plugin-pagefindfromapps/desktop/package.jsonpnpm-lock.yamlandCargo.lockto reflect removed dependenciesNote: The web app (
apps/web) uses a separatepagefindnpm package for static site search - this is unrelated to the Tauri plugin and was intentionally left unchanged.Updates since last revision
ERR_PNPM_OUTDATED_LOCKFILEReview & Testing Checklist for Human
apps/desktop/src/imports or calls@hypr/plugin-pagefindcommands (buildIndex,getBundlePath,clearIndex)actix-*packages removed (were pagefind dependencies) - confirm this is expectedRecommended test plan: Run
pnpm -F desktop tauri buildorpnpm -F desktop tauri devto verify the app compiles and runs without the pagefind plugin.Notes